This repository was archived by the owner on Nov 27, 2020. It is now read-only.
Updating symfony/phpunit-bridge version constraint #947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,7 +24,7 @@ | |||
| }, | |||
| "require-dev": { | |||
| "sensio/generator-bundle": "^3.0", | |||
| "symfony/phpunit-bridge": "^2.7" | |||
| "symfony/phpunit-bridge": "^2.7|^3.0" | |||
There was a problem hiding this comment.
What about to use "symfony/phpunit-bridge": "^3.0" for Symfony 3.0?
There was a problem hiding this comment.
+1 here we are on the master branch so no need to comply with 2.x branch.
There was a problem hiding this comment.
Right! Revising PR now, ^2.7 is needed when backporting..
|
Since we are on master and with SF3.x, I updated this PR to request phpunit-bridge |
|
👍 Could be merged in 3.0 |
|
👍 |
|
Thank you @Jean85. |
|
You're welcome @fabpot ! |
|
@Jean85 we generally update run |
|
Ok great! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently installed Symfony 3.0.2, done a
composer updateand discovered (using vinkla/climb) that symfony/phpunit-bridge couldn't be updated to the latest major version. This should make the upgrade immediately executable on a fresh install.I didn't update the lock because v3 increases the minimum PHP version to 5.5.9, so this remains backward compatible with older PHP versions.