Skip to content

[FrameworkBundle] Fixed the tests #10130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2014

Conversation

jakzal
Copy link
Contributor

@jakzal jakzal commented Jan 25, 2014

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

This template was already converted to a one liner before in b85577b, but
that change was reverted when merging and solving conflicts from 2.3 branch (07de761).

… tests.

This was initially done in b85577b, but
reverted when merging and solving conflicts from 2.3 branch
(07de761).
fabpot added a commit that referenced this pull request Jan 25, 2014
This PR was merged into the 2.4 branch.

Discussion
----------

[FrameworkBundle] Fixed the tests

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This template was already converted to a one liner before in b85577b, but
that change was reverted when merging and solving conflicts from 2.3 branch (07de761).

Commits
-------

38691da [FrameworkBundle] Merged multiple line input into one line to fix the tests.
@fabpot fabpot merged commit 38691da into symfony:2.4 Jan 25, 2014
@lavoiesl
Copy link
Contributor

Can this be merged into master as well ?

lavoiesl referenced this pull request Jan 26, 2014
* 2.3: (30 commits)
  Update validators.ro.xlf
  add non-standard port to HTTP_HOST
  fixed attribute "source-language" for translations
  Update PluralizationRules.php
  Update validators.pt_BR.xlf
  Translated remaining items (57-72)
  Updated Vietnamese translation
  added missing dot in translation
  updated Arabic translations
  Update validators.id.xlf
  [Validator] Translate validator messages into Brazilian Portuguese
  Added more Swedish validator translations
  Update validators.ca.xlf
  fixed typos in Welsh translation
  Added missing Croatian translations
  [Form] fixed allow render 0 and 0.0 numeric input values
  Fixed validators.nl.xlf
  [Component/Security] Fixed some phpdocs in Security/Core
  Completed Luxembourgish translation
  Fixing the Logger deprecation notices to match the correct method name it should be informing of
  ...

Conflicts:
	src/Symfony/Bridge/Twig/composer.json
	src/Symfony/Bundle/FrameworkBundle/Resources/views/Form/form_widget_simple.html.php
	src/Symfony/Component/Console/Application.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants