[Cache] Test & tweak CacheItem::validateKey() #18604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| class CacheItemTest extends \PHPUnit_Framework_TestCase | ||
| { | ||
| public function testValideKey() |
nicolas-grekas
force-pushed
the
cache-validate
branch
from
1333d30 to
1fccfb8
Compare
nicolas-grekas
force-pushed
the
cache-validate
branch
from
1fccfb8 to
4256add
Compare
|
👍 It looks very nice to me. @nicolas-grekas thanks for this PR ... and thanks for your patience 🙏 |
|
Thanks to you @javiereguiluz , you had a good point, sorry for merging too fast today :) |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 20, 2016
…rekas) This PR was merged into the 3.1-dev branch. Discussion ---------- [Cache] Test & tweak CacheItem::validateKey() | Q | A | ------------- | --- | Branch? | 3.1 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Ping @javiereguiluz @stof Commits ------- 4256add [Cache] Test & tweak CacheItem::validateKey()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ping @javiereguiluz @stof