Skip to content

[Lock] Simplify BlockingTest #22121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2017
Merged

Conversation

jderusse
Copy link
Member

@jderusse jderusse commented Mar 23, 2017

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@jderusse jderusse force-pushed the lock-fix-tests branch 2 times, most recently from 154ed9e to 74960aa Compare March 23, 2017 00:56
@jderusse
Copy link
Member Author

Trigger 3/3 successfully build.

https://travis-ci.org/symfony/symfony/builds/214069252
https://travis-ci.org/symfony/symfony/builds/214071713
https://travis-ci.org/symfony/symfony/builds/214076363

  1. Failled test is not related to this Component.
  2. Not exactly the same travis.yml to be able to build php 7.1 with the lock component

@jderusse jderusse force-pushed the lock-fix-tests branch 3 times, most recently from da0ef1e to b5a25b8 Compare March 23, 2017 20:15
@nicolas-grekas nicolas-grekas added this to the 3.3 milestone Mar 24, 2017
@jderusse jderusse force-pushed the lock-fix-tests branch 3 times, most recently from 662b9fb to e5417fc Compare March 31, 2017 19:49
@jderusse jderusse changed the title [WIP] [Lock] Simplify BlockingTest [Lock] Simplify BlockingTest Mar 31, 2017
@jderusse
Copy link
Member Author

jderusse commented Apr 1, 2017

After several successful builds, I think this PR is ready to be merged. It will stabilize tests.

@fabpot
Copy link
Member

fabpot commented Apr 2, 2017

Thank you @jderusse.

@fabpot fabpot merged commit 7130dd8 into symfony:master Apr 2, 2017
fabpot added a commit that referenced this pull request Apr 2, 2017
This PR was merged into the 3.3-dev branch.

Discussion
----------

[Lock] Simplify BlockingTest

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

7130dd8 Simplify BlockingTest
@jderusse jderusse deleted the lock-fix-tests branch May 1, 2017 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants