[TwigBridge] update test for Twig performance optimizations #25970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Jan 30, 2018
xabbuh
commented
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | twigphp/Twig#2617 |
| License | MIT |
| Doc PR |
|
That works only with the next version of Twig, so we need to bump Twig's versions. |
|
this should be done with a different case, checking both the environment major version and the minor version IMO, instead of forbidding older minor versions strictly. |
|
I am not sure if it's worth it, but taken that into account doesn't add much complexity. So here we go. |
javiereguiluz
approved these changes
Jan 31, 2018
|
Thank you @xabbuh. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 31, 2018
…ons (xabbuh) This PR was merged into the 2.7 branch. Discussion ---------- [TwigBridge] update test for Twig performance optimizations | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | twigphp/Twig#2617 | License | MIT | Doc PR | Commits ------- 21bbad9 update test for Twig performance optimizations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.