Remove redundant path check #28683
Merged
Remove redundant path check #28683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first `if` statement in this method already performs this same check, so the expression here always evaluated to `true`.
|
The code standard violation identified by fabbot.io is due to unrelated code in this file. |
BTW, I disabled the rule to add the "b" in a164bb9 |
nicolas-grekas
approved these changes
Oct 2, 2018
javiereguiluz
approved these changes
Oct 2, 2018
fabpot
approved these changes
Oct 3, 2018
|
Thank you @colinodell. |
fabpot
added a commit
that referenced
this pull request
Oct 3, 2018
This PR was merged into the 2.8 branch. Discussion ---------- Remove redundant path check | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | maybe? | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Commit 0ec852d introduced this new method. As you can see, the code I'm removing always evaluates to `true` thanks to the first `if` statement in this method:  (I'm not sure if redundant code technically counts as a "bug", so I've assumed "yes it does" and targeted 2.8.) Commits ------- 10795cf Remove redundant path check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 0ec852d introduced this new method. As you can see, the code I'm removing always evaluates to
truethanks to the firstifstatement in this method:(I'm not sure if redundant code technically counts as a "bug", so I've assumed "yes it does" and targeted 2.8.)