Skip to content

Fix class documentation #28770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2018
Merged

Fix class documentation #28770

merged 1 commit into from
Oct 8, 2018

Conversation

luxifer
Copy link
Contributor

@luxifer luxifer commented Oct 8, 2018

Q A
Branch? 2.8
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

The phpdoc references the PHP flush function, neither a method of this class nor its parent.

The phpdoc references the PHP flush function, neither a method of this class nor its parent.
@fabpot
Copy link
Member

fabpot commented Oct 8, 2018

Good catch, thanks @luxifer.

@fabpot fabpot merged commit 5a51bb2 into symfony:2.8 Oct 8, 2018
fabpot added a commit that referenced this pull request Oct 8, 2018
This PR was merged into the 2.8 branch.

Discussion
----------

Fix class documentation

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

The phpdoc references the PHP flush function, neither a method of this class nor its parent.

Commits
-------

5a51bb2 Fix class documentation
@luxifer
Copy link
Contributor Author

luxifer commented Oct 8, 2018

You're welcome 😉

@luxifer luxifer deleted the patch-1 branch October 8, 2018 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants