[Translation] Dont test full string output #40933
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
|
Hm.. maybe Im more happy with #40934 |
|
I'd prefer #40934 as well. |
derrabus
added a commit
that referenced
this pull request
Apr 24, 2021
This PR was merged into the 5.3-dev branch. Discussion ---------- [Translation] [CI] Specify terminal width | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | This is an alternative to #40933. It will force to use 121 (120 max) characters as width. Commits ------- d51f7f6 [Translation] [CI] Specify terminal width
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SymfonyStylewill automatically detect the terminal width and insert line breaks. When we test for "super long" string in the output, it will likely fail because of those line breaks.This is a quick fix, I think we can solve this in a more generic and elegant way in the future.. But Im not sure exactly how atm.