Skip to content

[Messenger] Update ExceptionInterface.php #46969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Conversation

94noni
Copy link
Contributor

@94noni 94noni commented Jul 18, 2022

Q A
Branch? 4.4
Bug fix? yes~no
New feature? no
Deprecations? no
Tickets Fix wording in class comment
License MIT

Not the PR of the year, but for me it is worth it

Copy link
Member

@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe…

Base exception of the Messenger component

?

@94noni
Copy link
Contributor Author

94noni commented Jul 18, 2022

@derrabus I've opened severals symfony/components/(dotenv|passwordhasher|console) etc and each one have its own naming, thus maybe this small change is enough :)

@derrabus
Copy link
Member

Good catch, thanks @94noni.

@derrabus derrabus merged commit ec69d4e into symfony:4.4 Jul 18, 2022
@carsonbot carsonbot changed the title Update ExceptionInterface.php [Messenger] Update ExceptionInterface.php Jul 18, 2022
@94noni 94noni deleted the patch-1 branch July 18, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants