Skip to content

[Security][Serializer] Add missing args to trigger_deprecation #47955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2022

Conversation

alamirault
Copy link
Contributor

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #...
License MIT
Doc PR symfony/symfony-docs#...

I found that an argument was missing to trigger_deprecation in AuthorizationChecker. Found other places with this problem.

@carsonbot carsonbot added this to the 5.4 milestone Oct 22, 2022
@alamirault alamirault force-pushed the hotfix/fix-trigger-deprecation-args branch from 22d7e07 to 2d3bf8c Compare October 22, 2022 20:31
Copy link
Member

@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catches!

@alamirault alamirault requested review from derrabus and removed request for dunglas, wouterj and chalasr October 22, 2022 21:31
@carsonbot carsonbot changed the title Add missing args to trigger_deprecation [Security] Add missing args to trigger_deprecation Oct 22, 2022
@carsonbot carsonbot changed the title [Security] Add missing args to trigger_deprecation [Security][Serializer] Add missing args to trigger_deprecation Oct 22, 2022
@fabpot fabpot force-pushed the hotfix/fix-trigger-deprecation-args branch from 699c3e3 to 1114ea8 Compare October 23, 2022 09:52
@fabpot
Copy link
Member

fabpot commented Oct 23, 2022

Good catch, thanks @alamirault.

@fabpot fabpot merged commit d39de28 into symfony:5.4 Oct 23, 2022
This was referenced Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants