[DependencyInjection] Add support for Exclude attribute #49492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lyrixx
commented
Feb 22, 2023
lyrixx
commented
| Q | A |
|---|---|
| Branch? | 6.3 |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | no |
| Tickets | Fix #46643 |
| License | MIT |
| Doc PR |
src/Symfony/Component/DependencyInjection/Loader/FileLoader.php
Outdated
Show resolved
Hide resolved
lyrixx
force-pushed
the
exclude
branch
3 times, most recently
from
3a93c5d to
66af40f
Compare
| } | ||
|
|
||
| /** | ||
| * @dataProvider provideRegisterClassesWithExcludeAttributeTests |
There was a problem hiding this comment.
let's replace the provider with @testWith [true] [false]
|
FTR: This feature has been discussed and rejected once: #46655 |
|
Why not just adding the attribute suggested in #47196? #[Attribute(Attribute::TARGET_CLASS | Attribute::TARGET_METHOD | Attribute::TARGET_FUNCTION | Attribute::IS_REPEATABLE)]
final class Exclude extends When
{
public function __construct()
{
parent::__construct('never');
}
} |
|
@derrabus I know but I think many people need it @alanpoulain because this is a hack 😊 |
nicolas-grekas
approved these changes
Feb 22, 2023
nicolas-grekas
force-pushed
the
exclude
branch
from
66af40f to
cd64c67
Compare
|
Thank you @lyrixx. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.