[DependencyInjection] Add support for #[Autowire(lazy: true)]
#49685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Mar 19, 2023
src/Symfony/Component/DependencyInjection/Tests/Dumper/PhpDumperTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Attribute/Autowire.php
Outdated
Show resolved
Hide resolved
|
Needs a rebase. |
|
Rebased + comments addressed, thanks. |
|
Thank you @nicolas-grekas. |
nicolas-grekas
added a commit
that referenced
this pull request
Mar 28, 2023
…: class-string)]` (nicolas-grekas) This PR was merged into the 6.3 branch. Discussion ---------- [DependencyInjection] Add support for `#[Autowire(lazy: class-string)]` | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - This PR finishes what started in #49685. It adds support for defining the interfaces to proxy when using laziness with the Autowire attribute. ```php public function __construct( #[Autowire(service: 'foo', lazy: FooInterface::class)] FooInterface|BarInterface $foo, ) { } ``` It also adds support for lazy-autowiring of intersection types: ```php public function __construct( #[Autowire(service: 'foobar', lazy: true)] FooInterface&BarInterface $foobar, ) { } ``` Commits ------- d127ebf [DependencyInjection] Add support for `#[Autowire(lazy: class-string)]`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a feature that I anticipated during my talk at SymfonyCon DisneyLand.
This PR adds support for using
#[Autowire(lazy: true)]on an argument to tell the container to generate a lazy service and pass it to that argument.This works by creating a lazy service from the autowiring alias: if the argument targets
FooInterface, a lazy service is declared (named.lazy.FooInterface) and injected. The originalFooInterfaceremains unchanged, aka non-lazy.This allows services that don't always consume their deps to initialize them only when actually needed.