[VarDumper] Fix generator dump on PHP 8.4 #57191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandre-daubois
force-pushed
the
generator-84
branch
from
1bce686 to
7ddc5ec
Compare
xabbuh
reviewed
May 27, 2024
| } catch (\Exception $e) { | ||
| $a[Caster::PREFIX_VIRTUAL.'closed'] = true; | ||
|
|
||
| return $a; |
There was a problem hiding this comment.
Why not keep this line and remove the return statement below entirely instead (IMO makes the diff more understandable)?
There was a problem hiding this comment.
Wasn't sure which solution is the most readable, let's take your suggestion
alexandre-daubois
force-pushed
the
generator-84
branch
from
7ddc5ec to
fc0dc0e
Compare
|
Thank you @alexandre-daubois. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From PHP 8.4, generators dump contains the generating function: php/php-src#14167.
Also, creating a ReflectionGenerator on a closed generator is now permitted, which explains the update in
ReflectionCasterto catch anything that may happen incastReflectionGenerator().