run tests using PHPUnit 11.5 #58370
Open
run tests using PHPUnit 11.5 #58370
+2,822
−2,108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
requested review from
welcoMattic,
dunglas,
OskarStark and
yceruto
as code owners
|
The PR cannot be merged at the moment as it is based on a bunch of other open pull requests that are paving the way to be able to actually run the tests with PHPUnit 11. |
xabbuh
force-pushed
the
phpunit11-integration-tests
branch
2 times, most recently
from
7178ae5 to
76245c5
Compare
|
This is super nice news! Did you already take care of everything required to be "PHPUnit 11 compliant" in already opened PRs ? |
|
@alexandre-daubois The "ensure session storages are opened before destroying them" commit is the only one that is not already part of an open PR. I do not really understand yet why that change is necessary (the flow in |
xabbuh
force-pushed
the
phpunit11-integration-tests
branch
from
76245c5 to
24d86e8
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Sep 25, 2024
This PR was merged into the 5.4 branch. Discussion ---------- Tweak error/exception handler registration | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #53812 | License | MIT This should allow removing the custom bootstrap file from #58370 /cc `@xabbuh` The change on FrameworkBundle leads to a tweaked behavior: we don't override the previous error handler in case it's not the Symfony one. This shouldn't change anything in practice since the error handler is already registered by the runtime component. The rest is closer to bug fixes. Commits ------- af9c035 Tweak error/exception handler registration
|
We need a way to register DebugClassLoader, and maybe a few other things. Basically what we do in SymfonyTestsListenerTrait. |
xabbuh
force-pushed
the
phpunit11-integration-tests
branch
2 times, most recently
from
ab2f604 to
e56f932
Compare
xabbuh
changed the title
xabbuh
force-pushed
the
phpunit11-integration-tests
branch
from
e56f932 to
bddc3f5
Compare
xabbuh
force-pushed
the
phpunit11-integration-tests
branch
5 times, most recently
from
d72eadc to
c89477a
Compare
xabbuh
changed the title
xabbuh
changed the title
xabbuh
force-pushed
the
phpunit11-integration-tests
branch
from
a440ba5 to
1063ab5
Compare
xabbuh
force-pushed
the
phpunit11-integration-tests
branch
2 times, most recently
from
5e4fdba to
ae5c4c9
Compare
xabbuh
force-pushed
the
phpunit11-integration-tests
branch
5 times, most recently
from
1f1acda to
fb2eb1c
Compare
stof
reviewed
Jun 18, 2025
| @@ -129,7 +130,7 @@ jobs: | |||
| fi | |||
|
|
|||
| # Legacy tests are skipped when deps=high and when the current branch version has not the same major version number as the next one | |||
There was a problem hiding this comment.
should this be removed ? You removed the legacy group so this will probably not work anymore.
There was a problem hiding this comment.
You are right. For now this would work as the group is present in the 6.4 branch (see also #58370 (comment)). We need to decide which approach we do want to take.
xabbuh
force-pushed
the
phpunit11-integration-tests
branch
5 times, most recently
from
7db40f2 to
6944687
Compare
xabbuh
force-pushed
the
phpunit11-integration-tests
branch
from
6944687 to
1a81669
Compare
xabbuh
force-pushed
the
phpunit11-integration-tests
branch
3 times, most recently
from
5f2cce3 to
2c6e393
Compare
xabbuh
force-pushed
the
phpunit11-integration-tests
branch
from
2c6e393 to
247dbdf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.