minor #1258 [Doc] Fix preConnect/connect inversion in "disconnect()" doc examples (smnandre)

weaverryan · weaverryan · commit b675a1fbfc59 · 2023-12-12T11:45:17.000-05:00
This PR was merged into the 2.x branch. Discussion ---------- [Doc] Fix preConnect/connect inversion in "disconnect()" doc examples Following symfony/ux#1227 i found other similar cases of callback inversion in the documentation. Commits ------- 3f8218f5 Fix preConnect/connect inversion in "disconnect()" doc examples
diff --git a/doc/index.rst b/doc/index.rst
@@ -106,8 +106,8 @@ custom Stimulus controller:
 
         disconnect() {
             // You should always remove listeners when the controller is disconnected to avoid side effects
-            this.element.removeEventListener('cropperjs:pre-connect', this._onConnect);
             this.element.removeEventListener('cropperjs:connect', this._onConnect);
+            this.element.removeEventListener('cropperjs:pre-connect', this._onPreConnect);
         }
 
         _onPreConnect(event) {

Original file line number	Diff line number	Diff line change
`@@ -106,8 +106,8 @@ custom Stimulus controller:`
`106`	`106`
`107`	`107`	`disconnect() {`
`108`	`108`	`// You should always remove listeners when the controller is disconnected to avoid side effects`
`109`		`- this.element.removeEventListener('cropperjs:pre-connect', this._onConnect);`
`110`	`109`	`this.element.removeEventListener('cropperjs:connect', this._onConnect);`
	`110`	`+ this.element.removeEventListener('cropperjs:pre-connect', this._onPreConnect);`
`111`	`111`	`}`
`112`	`112`
`113`	`113`	`_onPreConnect(event) {`