[Autocomplete][Doc] Fix event listeners are not removed #1227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kind poke @weaverryan (as the online version could confuse users) |
Merged
|
Fixed in #1272 ... because I checked the PR's in the wrong order. Thanks Simon :) |
weaverryan
added a commit
that referenced
this pull request
Dec 12, 2023
…doc examples (smnandre) This PR was merged into the 2.x branch. Discussion ---------- [Doc] Fix preConnect/connect inversion in "disconnect()" doc examples Following #1227 i found other similar cases of callback inversion in the documentation. Commits ------- 3f8218f Fix preConnect/connect inversion in "disconnect()" doc examples
symfony-splitter
pushed a commit
to symfony/ux-cropperjs
that referenced
this pull request
Dec 12, 2023
…doc examples (smnandre) This PR was merged into the 2.x branch. Discussion ---------- [Doc] Fix preConnect/connect inversion in "disconnect()" doc examples Following symfony/ux#1227 i found other similar cases of callback inversion in the documentation. Commits ------- 3f8218f5 Fix preConnect/connect inversion in "disconnect()" doc examples
symfony-splitter
pushed a commit
to symfony/ux-swup
that referenced
this pull request
Dec 12, 2023
…doc examples (smnandre) This PR was merged into the 2.x branch. Discussion ---------- [Doc] Fix preConnect/connect inversion in "disconnect()" doc examples Following symfony/ux#1227 i found other similar cases of callback inversion in the documentation. Commits ------- 3f8218f5 Fix preConnect/connect inversion in "disconnect()" doc examples
symfony-splitter
pushed a commit
to symfony/ux-typed
that referenced
this pull request
Dec 12, 2023
…doc examples (smnandre) This PR was merged into the 2.x branch. Discussion ---------- [Doc] Fix preConnect/connect inversion in "disconnect()" doc examples Following symfony/ux#1227 i found other similar cases of callback inversion in the documentation. Commits ------- 3f8218f5 Fix preConnect/connect inversion in "disconnect()" doc examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the documentation snippet, causing listeners to not be removed on disconnect.
From
To