Skip to content

[TwigComponent] Remove undefined var $name in ComponentExtension #1117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2023
Merged

[TwigComponent] Remove undefined var $name in ComponentExtension #1117

merged 1 commit into from
Sep 18, 2023

Conversation

smnandre
Copy link
Member

@smnandre smnandre commented Sep 14, 2023 •
edited
Loading

Q A
Bug fix? yes
New feature? no
Tickets Fix #1115
License MIT

Implement the solution suggested by @kbond here: #1115 (comment)

kbond
kbond approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@kbond kbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this!

sneakyvv
sneakyvv approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@sneakyvv sneakyvv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is some copy pasta :\

The method could be altered so the name of the component is available and that the regular exception could be thrown, but since this is at the end of rendering it isn't appropriate after all.
TL;DR: removing this is ok 👍

@weaverryan
Copy link
Member

Thanks Simon!

@weaverryan weaverryan merged commit fe076a9 into symfony:2.x Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbond kbond kbond approved these changes

@sneakyvv sneakyvv sneakyvv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TwigComponent] Undefined var $name in ComponentExtension ?
4 participants
@smnandre @weaverryan @kbond @sneakyvv