[CS] Update PhpCsFixer config

[smnandre]

I took some time to check the .php-cs-fixer.dist.php file and

• compared it to symfony/symfony one
• checked the rules included in the rulesets (@Symfony @Symfony:risky and @PHPUnit75Migration:risky)

Rules already in one of the rulesets:

• php_unit_dedicate_assert -> in @PHPUnit75Migration:risky
• array_syntax -> in @symfony
• combine_nested_dirname -> in @symfony:risky
• native_constant_invocation -> in @symfony:risky (with ['strict' => false) bug do we need the difference?)

Rules unneeded:

• protected_to_private -> disabled per default
• fopen_flags -> no fopen call in this repository code

Rules i suggest to remove:

• list_syntax -> not sure to see the necessity of this rule, do we need it ?
• ordered_imports -> already in @symfony (with a different order, but the same order present in PSR and PHPCSFIXER rulesets)

--

I also realised there is no rule to include the symfony licence header in every PHP files, should we add it ? (done)

---

Updated config:

 ->setRules([
        '@PHPUnit75Migration:risky' => true,
        '@Symfony' => true,
        '@Symfony:risky' => true,
        'header_comment' => ['header' => $fileHeaderComment],
])

[weaverryan]

I also realised there is no rule to include the symfony licence header in every PHP files, should we add it ?

Yup - that'd be great 👍

[smnandre]

Rule added / applied

[weaverryan]

list_syntax -> not sure to see the necessity of this rule, do we need it ?

No idea - we can remove it and see what happens. Reading your notes, if there are other changes you want to make, go ahead and make them and we'll see how they look.

[smnandre]

I'm happy with this config :)

I'm gonna suggest some other CI updates now 👼

[weaverryan]

Thanks Simon!