[Live] Throwing an error when setting an invalid model name #1216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #535
Currently, if you use an invalid prop/model name in
data-model, there is no error: the field is just silently not set. Now, we throw a clear error.It's possible (?) that people were relying on this - notably if someone is using a
<form data-model="*">to auto-map every form field as a model... but only some exist on their component. However, 99% of the time people are using that with a Symfony form +ComponentWithFormTrait, where that will not be an issue. And I think if you havedata-model="*", you are saying that every field is a prop. For the sake of DX, we should fail loudly and not let users make accidents.Cheers!