Add a note about using raw data attributes as a prefered way #1336
Conversation
|
I need to check the PR still, but I’m also preferring the direct attributes these days. |
| <!-- would render --> | ||
| <div data-controller="hello"> | ||
| ... | ||
| </div> |
There was a problem hiding this comment.
We should update a bit more, starting with the "Use the Twig functions..." line. Something like:
Then, activate the controller in your HTML:
(show the raw data-controller example).
Then after, something like:
Optionally, this bundle has a Twig function to render the attribute:
(show the stimulus_controller())
src/StimulusBundle/doc/index.rst
Outdated
| .. note:: | ||
|
|
||
| Though this bundle provides these helpful functions/filters, it's recommended to | ||
| use raw data attributes instead. If you use PhpStorm - you may want to install |
There was a problem hiding this comment.
attributes instead, as they're simple enough. If you use...
src/StimulusBundle/doc/index.rst
Outdated
| Though this bundle provides these helpful functions/filters, it's recommended to | ||
| use raw data attributes instead. If you use PhpStorm - you may want to install | ||
| [Stimulus plugin](https://plugins.jetbrains.com/plugin/18940-stimulus) that will | ||
| bring you nice autocompletion for them. |
There was a problem hiding this comment.
Stimulus plugin to get nice auto-completion for the attributes
|
@weaverryan done! Thanks for the review! |
|
|
||
| Though this bundle provides these helpful Twig functions/filters, it's | ||
| recommended to use raw data attributes instead, as they're simple enough. | ||
| If you use PhpStorm IDE - you may want to install |
There was a problem hiding this comment.
I would add this phrase as a tip bloc :)
src/StimulusBundle/doc/index.rst
Outdated
| .. note:: | ||
|
|
||
| Though this bundle provides these helpful Twig functions/filters, it's | ||
| recommended to use raw data attributes instead, as they're simple enough. |
There was a problem hiding this comment.
Perhaps replace « simple enough » with « straight forward » ?
|
@94noni thank you for your review, done! |
|
Thanks Victor! |
Now with the Stimulus plugin autocomplete in PhpStorm it's better to use raw data attributes instead of built-in functions/filters. Normal Stimulus code is more readable and cleaner IMO.