Skip to content

[CI][Tests] Use static dataProvider #1393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Cropperjs/tests/CropperjsBundleTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
*/
class CropperjsBundleTest extends TestCase
{
public function provideKernels()
public static function provideKernels()
{
yield 'empty' => [new EmptyAppKernel('test', true)];
yield 'framework' => [new FrameworkAppKernel('test', true)];
Expand Down
2 changes: 1 addition & 1 deletion src/Dropzone/tests/DropzoneBundleTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
*/
class DropzoneBundleTest extends TestCase
{
public function provideKernels()
public static function provideKernels()
{
yield 'empty' => [new EmptyAppKernel('test', true)];
yield 'framework' => [new FrameworkAppKernel('test', true)];
Expand Down
2 changes: 1 addition & 1 deletion src/LazyImage/tests/LazyImageBundleTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
*/
class LazyImageBundleTest extends TestCase
{
public function provideKernels()
public static function provideKernels()
{
yield 'empty' => [new EmptyAppKernel('test', true)];
yield 'framework' => [new FrameworkAppKernel('test', true)];
Expand Down
2 changes: 1 addition & 1 deletion src/Notify/tests/Twig/NotifyRuntimeTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public function testStreamNotifications(array $params, string $expected)
$this->assertSame($expected, $rendered);
}

public function streamNotificationsDataProvider(): iterable
public static function streamNotificationsDataProvider(): iterable
{
$publicUrl = 'http://localhost:9090/.well-known/mercure';

Expand Down
2 changes: 1 addition & 1 deletion src/Translator/tests/Intl/IntlMessageParserTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public function testIntlMessageParser(string $message, array $expectedAst): void
static::assertEquals($expectedAst, $intlMessageParser->parse());
}

public function provideParse()
public static function provideParse()
{
yield 'no parameters' => [
'Hello world!',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public function testExtract(string $message, array $expectedParameters)
static::assertEquals($expectedParameters, $intlMessageParametersExtractor->extract($message));
}

public function provideExtract()
public static function provideExtract()
{
yield [
'Symfony is great!',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public function testExtract(string $message, array $expectedParameters): void
static::assertEquals($messageParametersExtractor->extract($message), $expectedParameters);
}

public function provideExtract()
public static function provideExtract()
{
yield [
'Symfony is great!',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public function testPrint(array $parameters, string $expectedTypeScriptType)
static::assertSame($expectedTypeScriptType, $typeScriptMessageParametersPrinter->print($parameters));
}

public function providePrint()
public static function providePrint()
{
yield [
[],
Expand Down
2 changes: 1 addition & 1 deletion src/Translator/tests/UxTranslatorBundleTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

class UxTranslatorBundleTest extends TestCase
{
public function provideKernels()
public static function provideKernels()
{
yield 'empty' => [new EmptyAppKernel('test', true)];
yield 'framework' => [new FrameworkAppKernel('test', true)];
Expand Down