Skip to content

[CI] Trim yarn JSON in run-vitest-all #1441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

smnandre
Copy link
Member

@smnandre smnandre commented Feb 1, 2024

On macOS, yarn workspaces info outputs some time/debug info outside the JSON, making it impossible to parse.

Trying to find a way to avoid that without messing with the script / other OS

-workspaces_info=$(yarn workspaces info)
+workspaces_info=$(yarn workspaces info | sed '1d;$d')

cc @evertharmeling

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Feb 1, 2024
@evertharmeling
Copy link
Contributor

Nice! Works for me, hopefully it didn't keep you up all night 😉

for the record, I'm on Monterey (12.7.1) and zsh (5.8.1 (x86_64-apple-darwin21.0))

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Feb 1, 2024
@smnandre
Copy link
Member Author

smnandre commented Feb 1, 2024

for the record, I'm on Monterey (12.7.1) and zsh (5.8.1 (x86_64-apple-darwin21.0))

macOS 14.2.1 // zsh 5.9 and ... yarn 1.22 🙊

@weaverryan weaverryan force-pushed the ci/fix-run-vitest-yarn-json branch from 5d97c10 to 6adb5f6 Compare February 1, 2024 17:56
@weaverryan
Copy link
Member

Thanks Simon! Hopefully this will work for everyone :)

@weaverryan weaverryan merged commit 1e47bb3 into symfony:2.x Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants