-
-
Notifications
You must be signed in to change notification settings - Fork 364
[Site] Add changelog page #1466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks cute and works nicely. 2 questions:
- We're repeating what's on GH. So I want to be clear: what's our motivation / the advantage to having this up on the site?
- Where should we link to it? Or should we want for the new design to link?
|
9adf501
to
9fe8933
Compare
c43efe8
to
0ab76c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks super cool thanks @smnandre 🧡
And you have not yet seen the icons 🙊 |
Thanks a lot @pierredup for all the feedback / checks.. i think i've adress them all but as i moved things a bit, if you want to have a second look, feel free :) |
89bf1ae
to
2349a82
Compare
@smnandre when I try this PR locally I have |
Yep 100%, thank you! I've updated the cache conservation to one week, i prefer avoid any custom code to invalidate the items for now, as i think the next step will be to store the data :) |
Thanks Simon. |
Deployed! https://ux.symfony.com/changelog |
(little step by little step.... ;) )