Skip to content

[Site] Add changelog page #1466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2024
Merged

[Site] Add changelog page #1466

merged 1 commit into from
Apr 14, 2024

Conversation

smnandre
Copy link
Member

@smnandre smnandre commented Feb 7, 2024

(little step by little step.... ;) )

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Feb 7, 2024
Copy link
Member

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks cute and works nicely. 2 questions:

  1. We're repeating what's on GH. So I want to be clear: what's our motivation / the advantage to having this up on the site?
  2. Where should we link to it? Or should we want for the new design to link?

@weaverryan weaverryan added Status: Needs Work Additional work is needed and removed Status: Needs Review Needs to be reviewed labels Feb 15, 2024
@smnandre
Copy link
Member Author

  • We're repeating what's on GH. So I want to be clear: what's our motivation / the advantage to having this up on the site?
  • SEO (in a good "giving people what they do look for" kind of meaning)
  • github search is not reserved to logged users i think
  • showing activity on the site
  • it's fun
  • Where should we link to it? Or should we want for the new design to link?
  • footer at first, we'll see after ?

@carsonbot carsonbot added Status: Needs Review Needs to be reviewed and removed Status: Needs Work Additional work is needed labels Feb 15, 2024
@smnandre
Copy link
Member Author

WIP

Capture d’écran 2024-02-16 à 01 58 16

@smnandre smnandre changed the title [Site] Add changelog page [Site] Add changelog page (wip) Feb 16, 2024
@smnandre
Copy link
Member Author

Capture d’écran 2024-02-16 à 20 38 21 Capture d’écran 2024-02-16 à 20 38 30

@smnandre smnandre changed the title [Site] Add changelog page (wip) [Site] Add changelog page Feb 16, 2024
@smnandre smnandre requested a review from weaverryan February 16, 2024 19:41
Copy link
Contributor

@WebMamba WebMamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks super cool thanks @smnandre 🧡

@smnandre
Copy link
Member Author

Looks super cool thanks @smnandre 🧡

And you have not yet seen the icons 🙊

@smnandre
Copy link
Member Author

Thanks a lot @pierredup for all the feedback / checks.. i think i've adress them all but as i moved things a bit, if you want to have a second look, feel free :)

@smnandre smnandre force-pushed the site/changelog branch 2 times, most recently from 89bf1ae to 2349a82 Compare April 12, 2024 23:13
@WebMamba
Copy link
Contributor

@smnandre when I try this PR locally I have
Capture d’écran 2024-04-13 à 13 17 26
I have this error because to get the changelog you do a request to the github api, the thing is this github api have rate limiter that look really low. One of the solutions could be to increase the cache even more, one full day, or one week, or change the cache strategy having something that invalidate the cache in release days. WDYT?

@smnandre
Copy link
Member Author

@smnandre when I try this PR locally I [...]

Yep 100%, thank you!

I've updated the cache conservation to one week, i prefer avoid any custom code to invalidate the items for now, as i think the next step will be to store the data :)

@smnandre smnandre requested a review from WebMamba April 13, 2024 14:32
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Apr 14, 2024
@kbond
Copy link
Member

kbond commented Apr 14, 2024

Thanks Simon.

@kbond kbond merged commit 7b9773f into symfony:2.x Apr 14, 2024
@kbond
Copy link
Member

kbond commented Apr 14, 2024

Deployed! https://ux.symfony.com/changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants