[Site] Replace stimulus_* helpers with data-attributes

[smnandre]

Fixes #1514 - cc @seb-jean

@weaverryan : I had to adapt a bit the SourceCleaner to keep data-* attributes.

[seb-jean]

Great 💯

[weaverryan]

Thanks Simon!

[CMH-Benny]

May I ask what was the motivation of removing those helpers? One could use both notations but one is now just gone?

I used those helpers heavily, because especially the value-api is really verbose. You have to know how to convert the casing, need to put even multiple dashes here and there... It just makes the whole value API now harder to use imho. Not only will I have to refactor many places now, it will raise cognitive load for less afine collegues to parse for the values in the twig code to do adjustements.

Any chance we will get something else back that simplifies it as these helpers did before? @weaverryan @smnandre

[weaverryan]

I used those helpers heavily, because especially the value-api is really verbose

The helpers are still there in StimulusBundle and won't go away. So if you like them, keep using them. For most cases, I just now prefer to use the raw values attributes and I want to encourage people to give them a try. But sometimes they are a bit complex / ugly. Do whatever you like :)

[CMH-Benny]

Oh, thanks for clarifying that! I misread that this is only about the usage of the helpers, but not the helpers themself :D

I mean the helpers are also having their weaknesses, for example I had to merge two controllers with their values applied together, that is also kinda ugly, those cases are easier with the attributes, tho. But especially the values API is really suboptimal to write in an attribute way. Was there alternative ideas about those in the past?

It probably doesn't fit here perfectly, but when we are on that topic - Would it be possible to have the twig parser take care of that and have somthing like this:

<div data-controller="a_controller"
     a_controller#aValueFromThatController="foo" 
     :a_controller#anotherValue="{{ something.number }}"
>
....

Or is this way too complicated?

[smnandre]

Adding new syntax things can really increase the difficulty (not even talking about maintenance, doc, ..) so i'd like to avoid this.

But i do think some view helper can and should be used in some cases.