Skip to content

[Doc] Reword the section about the locale in Live Components #1539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

javiereguiluz
Copy link
Member

Q A
Bug fix? no
New feature? no
Issues -
License MIT

Context: we have a localized project that doesn't add the locale in the URL. When refreshing the page after any UX change, the local was lost.

I read the docs but I couldn't fully understand it. I thought this was only for projects that include the locale in the URLs. In any case, after asking to Kevin and Ryan, they told me that this solution also applied to my case. They were right ... so I propose a minor reword to make it more clear that this solution is for everybody that works on localized projects.

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Feb 22, 2024
Copy link
Member

@kbond kbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you remove the following line to make the CI happy?

.. _`localizes its URLs`: https://symfony.com/doc/current/translation/locale.html#translation-locale-url

@carsonbot carsonbot added Status: Needs Work Additional work is needed and removed Status: Needs Review Needs to be reviewed labels Feb 22, 2024
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Work Additional work is needed labels Feb 23, 2024
@kbond
Copy link
Member

kbond commented Feb 23, 2024

Thank you Javier.

@kbond kbond merged commit 43fa51a into symfony:2.x Feb 23, 2024
@javiereguiluz javiereguiluz deleted the doc_live_i18n branch February 23, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants