Skip to content

Using Typescript & Centralizing Builds #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

weaverryan
Copy link
Member

@weaverryan weaverryan commented Oct 29, 2021

Q A
Bug fix? No
New feature? Yes
Tickets None
License MIT

Depends on #141

Hi!

This PR converts the project to use TypeScript, but that in itself wasn't really the motivation.

Motivations / Changes

  • A) Standardize how we do things to be more like @hotwired/stimulus and other high-quality Stimulus libraries (like stimulus-use
  • B) Centralize the build processes: the "build", "test" and "lint" processes are now all centralized so that each "library" can focus on just doing its job.
  • C) This removes support for IE11 (see below).

B) Was the main motivator - before, each library was responsible for setting up their own test process and (more importantly) their own build process, which allowed for inconsistencies for what transformations we make, etc.

IE 11 Support Gone

Stimulus 3 dropped IE 11 support. This PR would be released with the version of Symfony UX that starts using Stimulus 3. So, we follow suit. It makes the builds smaller and makes (along with Typescript) our build process MUCH simpler.

It's pretty easy to see the difference in the built files - for example https://github.com/symfony/ux/pull/156/files#diff-72060cc03a17f489a2c7e84dd42fab25c7d19ee5154f0c493f00b91d6a13285b

TODOS

  • Some additional cleanup so that the TypeScript build process finishes without warnings (it already finishes without errors).

@weaverryan weaverryan force-pushed the typescript-central-build branch 4 times, most recently from 34a4876 to f0076a6 Compare November 5, 2021 00:26
@weaverryan weaverryan force-pushed the typescript-central-build branch from f0076a6 to 82c5a06 Compare November 26, 2021 00:11
@tgalopin tgalopin force-pushed the typescript-central-build branch from 5d10c4f to f8eb843 Compare November 29, 2021 22:10
@tgalopin
Copy link
Contributor

Thanks @weaverryan.

@tgalopin tgalopin merged commit ba4dd1b into symfony:main Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants