[Icons] Cache icon set list #1601
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norkunas
reviewed
Mar 10, 2024
| if (200 !== $response->getStatusCode()) { | ||
| throw new \RuntimeException('Could not fetch icon collections from iconify.design.'); | ||
| } | ||
| if (null === $collections = $response->toArray()) { |
There was a problem hiding this comment.
toArray never returns null
There was a problem hiding this comment.
Omg what did wrote ?
(the idea behind this PR was to prevent some unhandled 404 (when the icon set does not exists).. but with your refacto this is probably no more usefull)
There was a problem hiding this comment.
We can close it now i think ?
|
Closing in favor of #1594 |
kbond
added a commit
that referenced
this pull request
Mar 10, 2024
…kbond) This PR was squashed before being merged into the 2.x branch. Discussion ---------- [Icons] Improve cache warmup by looking at every string | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | Issues | n/a | License | MIT Improve working with dynamic icon names (inspired by https://v2.tailwindcss.com/docs/optimizing-for-production#writing-purgeable-html) ```twig {# This will be cached #} {{ ux_icon('flag-fr') }} {# This will NOT be cached #} {{ ux_icon('flag-' ~ locale) }} {% set flags = {fr: 'flag-fr', de: 'flag-de'} %} {# both "flag-fr" and "flag-de" will be cached #} {{ ux_icon(flags[locale]) }} ``` Closes #1601 Commits ------- c3f7627 [Icons] Improve cache warmup by looking at every string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should keep the list of iconset locally .. it will help a lot to limit the number of http request / checks / etc
(pr used as example, this would need a bit more test ^^)