[Icons] Rework cache warm #1608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbond
approved these changes
Mar 11, 2024
carsonbot
added
Status: Reviewed
kbond
force-pushed
the
fix/warm-cache-command
branch
from
d5d8e69 to
99b19f6
Compare
|
Thanks Simon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The warm cache took a lot of time because
And a looot of false positives caused lot of cache locks for nothing.
On ux.symfony.com project with this component, the PR make the icons detected from 1000+ to 1 :)
And the command is now way quicker to run.
The prefix-less icons are warmed by simply listing the SVG at the root of the asset/icons directory