Skip to content

[LiveComponent] Fix idiomorph dependency (fix #1567) #1631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

smnandre
Copy link
Member

Current idiomorph dependency does not work for some users with npm

Now it's available as a ES module it should fix the problem

Thanks @pcmmf for the hand

Current idiomorph dependency does not work for some users with npm

Now it's available as a ES module it should fix the problem

Thanks @pcmmf for the hand
@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Mar 19, 2024
Copy link
Contributor

@WebMamba WebMamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @smnandre! Looks good to me!

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Mar 20, 2024
@kbond
Copy link
Member

kbond commented Mar 21, 2024

Thanks Simon.

@kbond kbond merged commit 5f2fb7f into symfony:2.x Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants