Skip to content

[Autocomplete] Fix tests for ORM 3.0 #1638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2024
Merged

[Autocomplete] Fix tests for ORM 3.0 #1638

merged 1 commit into from
Mar 21, 2024

Conversation

smnandre
Copy link
Member

  • leverage Metadata::toArray to keep the "type" data
  • lighten some over-specific tests
  • document some changes
  • fix deprecation

Make the CI green again

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Mar 20, 2024
@smnandre
Copy link
Member Author

cc @evertharmeling @kbond

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Mar 21, 2024
@kbond kbond force-pushed the fix/autocomplete branch from 9dfdf7f to 9a79d2e Compare March 21, 2024 01:18
@kbond
Copy link
Member

kbond commented Mar 21, 2024

Thanks Simon.

@kbond kbond merged commit 057abdb into symfony:2.x Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbond kbond kbond approved these changes

Assignees
No one assigned
Labels
Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smnandre @kbond @carsonbot