[Doc] Tweaks and fixes for UX Icons docs #1641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had the intention to open another doc PR next week, with a list of 10/12 big icon sets with their prefix and an example (something i started to work on as command) 
Do you want to make a first pass ? Wait for me ? |
|
There's no hurry ... so we could consider this PR "as is" ... and when your command is ready, etc. we can update the docs to add that table with the Top 10 icon sets and their prefixes. Thanks |
kbond
approved these changes
Mar 21, 2024
carsonbot
added
Status: Reviewed
|
Thank you Javier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we should mention some of the popular icon sets so people googling for them and Symfony can find this page. Also, let's show the config file path in the config example. I'm not sure if we want that file path to be
config/packages/ux_icons.yamlIn #1602 we're making more changes to docs, so, if this PR is merged, I think it should be merged before #1602. Thanks!