Skip to content

[Doc] UX Icons doc tweaks #1663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Conversation

javiereguiluz
Copy link
Member

Q A
Bug fix? no
New feature? no
Issues -
License MIT

The docs contained some minor issues (understandable because the doc merge produced a ton of hard-to-solve conflicts 🙏 ). I fixed those and made some minor tweaks.

@javiereguiluz javiereguiluz added the docs Improvements or additions to documentation label Mar 27, 2024
@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Mar 27, 2024
`Tabler Icons`_ 5200 MIT tabler tabler:check
========================= ======= ========== =========== =================

- `Bootstrap Icons <https://icons.getbootstrap.com/>`_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These links still need to exist for the table below, no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right ... the list of links should be fixed a bit, not removed. I re-added it at the bottom of the article. Thanks!

Copy link
Member

@smnandre smnandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Javier, sans sorry for the mess :(

@smnandre
Copy link
Member

smnandre commented Apr 2, 2024

Why is Doctor RST unhappy ? :|

@javiereguiluz
Copy link
Member Author

It was because of a silly mistake on my side. Fixed!

@kbond kbond force-pushed the ux_icons_doc_tweaks branch from 59f2c66 to 4ef2251 Compare April 2, 2024 21:01
@kbond
Copy link
Member

kbond commented Apr 2, 2024

Thank you Javier.

@kbond kbond merged commit 6addeb3 into symfony:2.x Apr 2, 2024
@javiereguiluz javiereguiluz deleted the ux_icons_doc_tweaks branch April 5, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation Status: Needs Review Needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants