-
-
Notifications
You must be signed in to change notification settings - Fork 364
[Site] Add "Icons" menu item #1673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
smnandre
commented
Apr 2, 2024
- Add Icon menu item in nav
- Remove dead code
- Add test
- Fix footer links
Oops.. some override #1672 sorry :) |
I inserted changes from #1672 |
Hey @smnandre this is detail, but I think the new at the top of the icon nav item should be more visible. Maybe we can make it bigger? Or add a background around? In mobile, the new is far from the world Icon so we don't get that the new is for icon. See some screenshots here: |
1eb0e5f
to
6d467be
Compare
Fixed by ... removing it as it has not the same goal on desktop where we want from the homepage to show it.. In the menu were someone already look at this different pages it has less use i think. |
df20095
to
7f4981a
Compare
7f4981a
to
51a8d5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @smnandre it looks good!
There a few bugs in mobile that we should fix in other PRs. I gonna do an issue for it 😁
Let's merge this to give Icons more exposure ... and we can tweak it later if we don't like anything. Thanks Simon! and thanks Matheo for the review. |