Skip to content

[Site] Add "Icons" menu item #1673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Conversation

smnandre
Copy link
Member

@smnandre smnandre commented Apr 2, 2024

  • Add Icon menu item in nav
  • Remove dead code
  • Add test
  • Fix footer links

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Apr 2, 2024
@smnandre
Copy link
Member Author

smnandre commented Apr 2, 2024

Oops.. some override #1672 sorry :)

@smnandre
Copy link
Member Author

smnandre commented Apr 2, 2024

I inserted changes from #1672

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Apr 3, 2024
@WebMamba
Copy link
Contributor

WebMamba commented Apr 5, 2024

Hey @smnandre this is detail, but I think the new at the top of the icon nav item should be more visible. Maybe we can make it bigger? Or add a background around? In mobile, the new is far from the world Icon so we don't get that the new is for icon. See some screenshots here:
Capture d’écran 2024-04-05 à 23 40 39
Capture d’écran 2024-04-05 à 23 40 13

@smnandre
Copy link
Member Author

smnandre commented Apr 5, 2024

Hey @smnandre this is detail, but I think the new at the top of the icon na [...]

Fixed by ... removing it as it has not the same goal on desktop where we want from the homepage to show it.. In the menu were someone already look at this different pages it has less use i think.

@smnandre smnandre requested a review from WebMamba April 5, 2024 22:03
@carsonbot carsonbot added Status: Needs Review Needs to be reviewed and removed Status: Reviewed Has been reviewed by a maintainer labels Apr 5, 2024
Copy link
Contributor

@WebMamba WebMamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @smnandre it looks good!

There a few bugs in mobile that we should fix in other PRs. I gonna do an issue for it 😁

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Apr 9, 2024
@javiereguiluz
Copy link
Member

Let's merge this to give Icons more exposure ... and we can tweak it later if we don't like anything. Thanks Simon! and thanks Matheo for the review.

@javiereguiluz javiereguiluz merged commit b539dd2 into symfony:2.x Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants