[Site] Fix infinite demo CS #1725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbond
added a commit
that referenced
this pull request
Apr 14, 2024
This PR was squashed before being merged into the 2.x branch. Discussion ---------- [Icons] Fix Icon aliases not found | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | Issues | Fix #1721 | License | MIT I'm adding a dedicated functional test because aliases will require specific attention/code regarding automatic class generation. Update: other CS fails fixed in #1725 Commits ------- d8589c0 [Icons] Fix Icon aliases not found
kbond
approved these changes
Apr 14, 2024
carsonbot
added
Status: Reviewed
|
Thanks Simon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CS fixes