Skip to content

Update README.md #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update README.md #175

wants to merge 1 commit into from

Conversation

cadot-info
Copy link

patch import @hotwired/stimulus

Q A
Bug fix? yes
New feature? yes/no
Tickets Fix #...
License MIT

patch import @hotwired/stimulus
@Kocal
Copy link
Member

Kocal commented Nov 28, 2021

My review comment is not "resolved", please see #175 (comment) to understand why we don't need this change.

@weaverryan
Copy link
Member

I can totally understand the confusion. We've updated the documentation on main, but we have not released the code yet for this. We're in weird spot - my goal is to get us out of it (with a 2.0 release) this week. But this PR is incorrect - technically the code that it documents DOES use the new library (it's just that the code is incomplete).

And, btw, we will add some update notes to the SymfonyCasts tutorials about the new package name as soon as we get the release done here :).

Cheers!

@weaverryan weaverryan closed this Nov 29, 2021
@cadot-info
Copy link
Author

cadot-info commented Nov 29, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants