Skip to content

[Site] Fix input range colors #1756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Conversation

Kocal
Copy link
Member

@Kocal Kocal commented Apr 19, 2024

Q A
Bug fix? no
New feature? no
Issues Fix #...
License MIT

Following #1743 (comment), removing the custom CSS and configuring Bootstrap variables made the .form-range displays correctly in both Chrome and Firefox:

image image

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Apr 19, 2024
@Kocal
Copy link
Member Author

Kocal commented Apr 19, 2024

TBH I really don't like the actual colors, the track's gray is hardly visible due to the grey background, I will change it later this day to make it more visible:
image

@Kocal Kocal mentioned this pull request Apr 19, 2024
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Apr 19, 2024
@kbond
Copy link
Member

kbond commented Apr 19, 2024

Can you share a screenshot of dark mode?

@Kocal Kocal force-pushed the fix/site-range-display branch from 7a2e9a3 to 6879b28 Compare April 19, 2024 15:00
@Kocal
Copy link
Member Author

Kocal commented Apr 19, 2024

I've changed the track background to var(--bs-body-bg), the same one used by other inputs, which render:
image
image

@kbond
Copy link
Member

kbond commented Apr 19, 2024

Thank you Hugo.

@kbond kbond merged commit 9c5a2f3 into symfony:2.x Apr 19, 2024
@kbond
Copy link
Member

kbond commented Apr 19, 2024

Live now.

@Kocal Kocal deleted the fix/site-range-display branch April 19, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants