Skip to content

Add Srcset Functionality #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Add Srcset Functionality #176

wants to merge 7 commits into from

Conversation

phtmgt
Copy link

@phtmgt phtmgt commented Nov 29, 2021

Q A
Bug fix? no
New feature? yes
Tickets Fix #148
License MIT

This pull request adds srcset functionality to the bundle. It follows the same logic like 'src'.

Copy link
Contributor

@tgalopin tgalopin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, it's a small but nice improvement!

@weaverryan
Copy link
Member

Thank you for this @plamenh! I've opened #186 with your commit, just so I could rebase it onto the new build system. I'll merge it there :)

@weaverryan weaverryan closed this Dec 2, 2021
weaverryan added a commit that referenced this pull request Dec 3, 2021
This PR was squashed before being merged into the 2.x branch.

Discussion
----------

Rebasing srcset addition

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| Tickets       | Fixes #148
| License       | MIT

Just a rebase of #176 to get the new build system in there.

Cheers!

Commits
-------

62da8b1 Rebasing srcset addition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ux-lazy-image] Any plans to support srcset?
3 participants