[Chartjs] Rely on Stimulus values instead of custom attributes #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgalopin
force-pushed
the
values-charts
branch
from
cb0b182 to
2d9ad7c
Compare
weaverryan
reviewed
Nov 30, 2021
| @@ -38,9 +40,10 @@ public function load(array $configs, ContainerBuilder $container) | |||
| ->setPublic(false) | |||
| ; | |||
|
|
|||
| if (class_exists(Environment::class)) { | |||
| if (class_exists(Environment::class) && class_exists(StimulusTwigExtension::class)) { | |||
There was a problem hiding this comment.
Using willBeAvailable() would be nice, but it's not available until 5.3 https://github.com/symfony/symfony/blob/e9a702635a89e84d2c63f25d066e63d729017741/src/Symfony/Component/DependencyInjection/ContainerBuilder.php#L1460
tgalopin
force-pushed
the
values-charts
branch
from
2d9ad7c to
ebeaedb
Compare
|
Thank you Titouan! |
tgalopin
added a commit
that referenced
this pull request
Dec 7, 2021
…tributes (tgalopin, weaverryan) This PR was merged into the 2.x branch. Discussion ---------- [Cropperjs] Rely on Stimulus values instead of custom attributes | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | Tickets | - | License | MIT Follows #177 Commits ------- 5ad7e32 Putting all Cropper.js options under cropper_options e3327eb WIP 2f0df8b [Cropperjs] Rely on Stimulus values instead of custom attributes
symfony-splitter
pushed a commit
to symfony/ux-cropperjs
that referenced
this pull request
Dec 7, 2021
…tributes (tgalopin, weaverryan) This PR was merged into the 2.x branch. Discussion ---------- [Cropperjs] Rely on Stimulus values instead of custom attributes | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | Tickets | - | License | MIT Follows symfony/ux#177 Commits ------- 5ad7e32 Putting all Cropper.js options under cropper_options e3327eb WIP 2f0df8b [Cropperjs] Rely on Stimulus values instead of custom attributes
fullstackdeveloperwebapp
added a commit
to fullstackdeveloperwebapp/ux
that referenced
this pull request
Aug 1, 2023
…tributes (tgalopin, weaverryan) This PR was merged into the 2.x branch. Discussion ---------- [Cropperjs] Rely on Stimulus values instead of custom attributes | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | Tickets | - | License | MIT Follows symfony/ux#177 Commits ------- 5ad7e32 Putting all Cropper.js options under cropper_options e3327eb WIP 2f0df8b [Cropperjs] Rely on Stimulus values instead of custom attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation of Symfony UX 2.0, this PR replaces the usage of custom attributes by Stimulus values. It also add Webpack Encore as an optional dependency to leverage the
stimulus_controllerhelper it provides in the Twig extension.