Skip to content

[TwigComponent] add PreMount hook #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2021
Merged

[TwigComponent] add PreMount hook #189

merged 1 commit into from
Dec 4, 2021

Conversation

kbond
Copy link
Member

@kbond kbond commented Dec 3, 2021

Q A
Bug fix? no
New feature? yes
Tickets Fix #142
License MIT

@kbond kbond force-pushed the twig-component-pre-mount branch from f79fd55 to be5476e Compare December 3, 2021 21:31
weaverryan
weaverryan reviewed Dec 3, 2021
View reviewed changes
Copy link
Member

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool - just noticed a README thing!

@kbond kbond force-pushed the twig-component-pre-mount branch from be5476e to 9913151 Compare December 3, 2021 21:37
@weaverryan
Copy link
Member

Thanks Kevin!

@weaverryan weaverryan merged commit 89dc843 into symfony:2.x Dec 4, 2021
@kbond kbond deleted the twig-component-pre-mount branch December 4, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weaverryan weaverryan weaverryan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kbond @weaverryan