[Site] Use ux-icons (1/2) #1936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's ignore the cs-twig for now... that will require some work to fix the Twig CS Fixer "UX parser" i suppose (poke @VincentLanglet if you have an idea to where i should start) |
This is supposed to be fixed in 2.10.0 version https://github.com/VincentLanglet/Twig-CS-Fixer/releases/tag/2.10.0 |
|
Oh that's a great news :) Thank you ! |
|
Remaining cs-twig failures are fixed in #1935 |
smnandre
force-pushed
the
site/use-ux-icons
branch
from
15267f2 to
6a8d9aa
Compare
kbond
approved these changes
Jun 26, 2024
carsonbot
added
Status: Reviewed
|
Thanks Simon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass to switch from the old custom Icon component to ux-icons
Next step (once feature available on ux-icons)