Fix Turbo Mercure bridge dependency #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think should only allow 2.0. Otherwise you will have one lib trying to use stimulus and another using @hotwired/stimulus is you have a mix of 1.0 and 2.0 @kbond this is the issue you were talking about (we saw this also with twig/live components) - our test suite needs to be enhanced to catch these :) |
tgalopin
force-pushed
the
fix-turbo-mercure
branch
from
ec26f7e to
94b52a7
Compare
weaverryan
approved these changes
Dec 10, 2021
|
Thanks Tito! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the package should be able to handle both 1.x and 2.x without change. @weaverryan I guess this will require a dedicated tag right?