Skip to content

[Site] Clean cook #2020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2024
Merged

[Site] Clean cook #2020

merged 1 commit into from
Aug 1, 2024

Conversation

smnandre
Copy link
Member

@smnandre smnandre commented Aug 1, 2024

No description provided.

@carsonbot carsonbot added Site ux.symfony.com Status: Needs Review Needs to be reviewed labels Aug 1, 2024
Copy link
Member

@Kocal Kocal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments

@smnandre smnandre requested a review from Kocal August 1, 2024 11:15
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Aug 1, 2024
@WebMamba
Copy link
Contributor

WebMamba commented Aug 1, 2024

I ran the PR locally and it looks like the code is not highlighted anymore:

Capture d’écran 2024-08-01 à 14 22 07

@smnandre
Copy link
Member Author

smnandre commented Aug 1, 2024

It was ? I'll look at it

@smnandre
Copy link
Member Author

smnandre commented Aug 1, 2024

Did you check when you rebased last time ?

What I suppose here is that when you coded it, we used highlight js (hence the "<code language-php>".

Since we switched to tempest php. And it requires some tags around in Twig.

I'll look at it

@smnandre
Copy link
Member Author

smnandre commented Aug 1, 2024

Well i've done it for you @WebMamba ❤️

It's even simpler in the end, i removed all the markdown parsing/formatting from the Factory (except the FrontMatter but this will be cached soon).

The content is rendered like a template with the current Twig environment + extensions.

(and that allow us to not parse the markdown content when we don't display it, like on the cookbook index page)

Also fixed the CSS (code was not readable on light mode)

@kbond kbond force-pushed the feat/cookbook-adjustments branch from 858f0ac to 0c47803 Compare August 1, 2024 18:08
@kbond
Copy link
Member

kbond commented Aug 1, 2024

Thanks Simon.

@kbond kbond merged commit c69bd67 into symfony:2.x Aug 1, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Site ux.symfony.com Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants