-
-
Notifications
You must be signed in to change notification settings - Fork 364
[Site] Clean cook #2020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Site] Clean cook #2020
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments
ux.symfony.com/assets/images/cookbook/component-architecture-1280x720.png
Outdated
Show resolved
Hide resolved
ux.symfony.com/assets/images/cookbook/component-architecture-640x360.png
Outdated
Show resolved
Hide resolved
It was ? I'll look at it |
Did you check when you rebased last time ? What I suppose here is that when you coded it, we used highlight js (hence the " Since we switched to tempest php. And it requires some tags around in Twig. I'll look at it |
Well i've done it for you @WebMamba ❤️ It's even simpler in the end, i removed all the markdown parsing/formatting from the Factory (except the FrontMatter but this will be cached soon). The content is rendered like a template with the current Twig environment + extensions. (and that allow us to not parse the markdown content when we don't display it, like on the cookbook index page) Also fixed the CSS (code was not readable on light mode) |
858f0ac
to
0c47803
Compare
Thanks Simon. |
No description provided.