Skip to content

[Site] Configure Icons + fixes #2237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2024
Merged

Conversation

smnandre
Copy link
Member

@smnandre smnandre commented Oct 5, 2024

  • composer update
  • remove temporary "Icon" component
  • add ux_icons config file
  • fix icon classes
  • trim version from changelog titles

@carsonbot carsonbot added Site ux.symfony.com Status: Needs Review Needs to be reviewed labels Oct 5, 2024
@smnandre smnandre requested a review from Kocal October 5, 2024 11:05
Copy link
Member

@Kocal Kocal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking, but there are some class="Icon" occurences left :p

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Oct 5, 2024
@smnandre
Copy link
Member Author

smnandre commented Oct 5, 2024

Nitpicking, but there are some class="Icon" occurences left :p

No you're right thank you.. should be good now

@smnandre smnandre merged commit 19aee2d into symfony:2.x Oct 5, 2024
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Site ux.symfony.com Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants