[LiveComponent][doc] Document how to deal with locales #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can this be achieved by adding the locale prefix when importing the route? https://symfony.com/doc/current/routing.html#route-groups-and-prefixes I'd prefer suggesting this. Maybe a note in the docs/recipe? |
|
@kbond it looks like you are right and your approach seems much cleaner. I will follow up on that 👍 |
Lustmored
changed the title
live_component route
|
@kbond I don't think there is any recipe for live component (at least I couldn't find any), therefore I believe putting this in installation step instructions is enough. |
kbond
requested changes
Jan 21, 2022
weaverryan
approved these changes
Jan 21, 2022
kbond
approved these changes
Jan 21, 2022
weaverryan
force-pushed
the
fix-locale
branch
from
65745c1 to
205b882
Compare
|
Thank you Jakub! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locale was lost after any live component action. It turns out that simply by adding
{_locale}to the route fixes the issue even when no locales are configured (router still seems to injecten).