Skip to content

[Twig][Live] Require Symfony 5.4+ #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2022
Merged

[Twig][Live] Require Symfony 5.4+ #252

merged 1 commit into from
Jan 28, 2022

Conversation

kbond
Copy link
Member

@kbond kbond commented Jan 28, 2022

Q A
Bug fix? no
New feature? no
Tickets n/a
License MIT

Both @weaverryan and I agree that bumping the min requirement of these library's would be beneficial. The primary reason being, the usability pre-5.3 is sub-par. Component's cannot be autoconfigured with the AsTwigComponent/AsLiveComponent attributes - they must be tagged manually. Requiring 5.4 makes documentation simpler, cleans up the test suite, and fixes some other compatibility issues. We figured, as we require PHP 8.0 already, requiring Symfony 5.4+ would be palatable.

@kbond
Copy link
Member Author

kbond commented Jan 28, 2022

Pinging some community members who are clearly using these library's: @Lustmored, @seb-jean, @norkunas, @allejo, @mdoutreluingne, @sabat24, @BeyerJC, @benr77. Any thoughts/objections?

@norkunas
Copy link
Contributor

norkunas commented Jan 28, 2022

None from me, using 6.0+PHP8.1 for the project

@BeyerJC
Copy link
Contributor

BeyerJC commented Jan 28, 2022

I think its a good idea. My projects are all >=5.4 , so lets go :-)

@Lustmored
Copy link
Contributor

Same here - 6.0 and PHP8.1 only. In fact I was just thinking about that when making changes in test Kernel 😃

@sabat24
Copy link

sabat24 commented Jan 28, 2022

Keeping it up to date with last active Symphony's LTS version is perfectly fine for me.

@benr77
Copy link

benr77 commented Jan 28, 2022

Agreed - 5.4 as the minimum is fine by me and I also think it's sensible to make this change sooner rather than later.

@mdoutreluingne
Copy link
Contributor

It's totally understandable and acceptable to demand Symfony 5.4+, as it's an LTS release. Anyway, active projects have every interest in moving to Symfony 5.4 or more for security reasons and more... So let's go 👍

@kbond
Copy link
Member Author

kbond commented Jan 28, 2022

@symfony/mergers any objections?

Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@allejo
Copy link
Contributor

allejo commented Jan 28, 2022

No concerns here! Using PHP8.1 & Symfony 5.4 here 🥳

@kbond kbond merged commit 896f417 into symfony:2.x Jan 28, 2022
@kbond kbond deleted the twig-live-5.4 branch January 28, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.