-
-
Notifications
You must be signed in to change notification settings - Fork 364
[Twig][Live] Require Symfony 5.4+ #252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pinging some community members who are clearly using these library's: @Lustmored, @seb-jean, @norkunas, @allejo, @mdoutreluingne, @sabat24, @BeyerJC, @benr77. Any thoughts/objections? |
None from me, using 6.0+PHP8.1 for the project |
I think its a good idea. My projects are all >=5.4 , so lets go :-) |
Same here - 6.0 and PHP8.1 only. In fact I was just thinking about that when making changes in test Kernel 😃 |
Keeping it up to date with last active Symphony's LTS version is perfectly fine for me. |
Agreed - 5.4 as the minimum is fine by me and I also think it's sensible to make this change sooner rather than later. |
It's totally understandable and acceptable to demand Symfony 5.4+, as it's an LTS release. Anyway, active projects have every interest in moving to Symfony 5.4 or more for security reasons and more... So let's go 👍 |
@symfony/mergers any objections? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
No concerns here! Using PHP8.1 & Symfony 5.4 here 🥳 |
Both @weaverryan and I agree that bumping the min requirement of these library's would be beneficial. The primary reason being, the usability pre-5.3 is sub-par. Component's cannot be autoconfigured with the
AsTwigComponent
/AsLiveComponent
attributes - they must be tagged manually. Requiring 5.4 makes documentation simpler, cleans up the test suite, and fixes some other compatibility issues. We figured, as we require PHP 8.0 already, requiring Symfony 5.4+ would be palatable.