Skip to content

Ensure JS dist files are current in CI #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Conversation

kbond
Copy link
Member

@kbond kbond commented Feb 1, 2022

Q A
Bug fix? no
New feature? no
Tickets n/a
License MIT

This action job will fail if the dist files need to be rebuilt. Failure example.

@kbond kbond force-pushed the js-dist-current branch 2 times, most recently from fe0e5be to 6d71610 Compare February 1, 2022 13:54
Copy link
Member

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing tests are unrelated - we have an annoying stale element that sometimes fails

if: steps.changes.outputs.changed == 1
run: |
echo "JS dist files need to be rebuilt"
exit 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that UnicornGlobal/has-changes-action is really handy!

@kbond kbond merged commit 2c599ca into symfony:2.x Feb 1, 2022
@kbond kbond deleted the js-dist-current branch February 1, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants