[Live] migrate Hydration system to standard Symfony normalizers #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
reviewed
Feb 2, 2022
kbond
force-pushed
the
live-normalizer
branch
from
29378f0 to
2710215
Compare
kbond
changed the title
kbond
force-pushed
the
live-normalizer
branch
2 times, most recently
from
09de631 to
93aaa37
Compare
kbond
force-pushed
the
live-normalizer
branch
from
93aaa37 to
fd39e9d
Compare
kbond
changed the title
|
Seems very resonable and makes custom code unnecessary. Let's give it a try - thanks Kevin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes our custom hydration system and uses
symfony/serializerdirectly. Hydrators are now just (de)normalizer's registered with Symfony as normal.The serializer context (
['live-component' => true]) can be used to restrict (de)normalizers to just live component properties.