feat(ci): check changes after yarn build #31
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Kocal ! Can you avoid creating Draft PR please? It notifies everyone watching the repo for unnecessary reasons :) . Once your PR is ready we would be happy to review it though! Also, if you wish to get my personal opinion, come on the ux channel on Slack :) ! |
|
After discussing with @weaverryan I think the best course of action in the short term is to have a release script that includes building the dist file. I'll add it to the script we use. Thanks for the PR anway! |
|
Alright! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first iteration for #20 (comment).
We used a similar thing at work and it was enough for us, but maybe we should be more friendly/precise, like posting a comment on the PR with the list of files that have not been built.
WDYT @tgalopin?