[TwigComponent] Allow to pass stringable object as non mapped component attribute #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norkunas
force-pushed
the
stringable-objects
branch
from
597bd48 to
36fcec0
Compare
kbond
requested changes
May 6, 2022
…nt attribute
Sometimes we have some value objects that are meant to be provided as stimulus controller values and when using ``{{ component('..', { 'data-item-id-param': objectUuid }) }}` it throws an exception that attribute must be scalar.
Now it will allow to accept these objects.
norkunas
force-pushed
the
stringable-objects
branch
from
36fcec0 to
c1194db
Compare
kbond
approved these changes
May 6, 2022
weaverryan
reviewed
May 6, 2022
| @@ -71,6 +71,10 @@ public function create(string $name, array $data = []): MountedComponent | |||
|
|
|||
| // ensure remaining data is scalar | |||
| foreach ($data as $key => $value) { | |||
| if ($value instanceof \Stringable) { | |||
There was a problem hiding this comment.
Funny timing - we JUST did this with stimulus_controller() also. There, we went further and checked for __toString(): https://github.com/symfony/webpack-encore-bundle/pull/171/files#diff-aac7ca1aa215ab99c76587c963238c082fb42b7a4315344002b7df3046306b8fR64
There was a problem hiding this comment.
I don't believe we need to check for the method because this lib is PHP 8+.
|
Thanks Tomas! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we have some value objects that are meant to be provided as stimulus controller values and when using
{{ component('..', { 'data-item-id-param': objectUuid }) }}it throws an exception that attribute must be scalar.Now it will allow to accept these objects.
cc @kbond