Skip to content

[LiveComponent] Move defaultAction validation to compiler pass #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2022

Conversation

norkunas
Copy link
Contributor

@norkunas norkunas commented May 9, 2022

Q A
Bug fix? no
New feature? no
Tickets N/A
License MIT

Completes todo note which was in source code :)

Copy link
Member

@kbond kbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for doing this @norkunas! Just a rogue dump that needs to be removed :)

@norkunas norkunas force-pushed the default-action-validation branch from d160a24 to 367da01 Compare May 9, 2022 14:23
Copy link
Member

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@weaverryan
Copy link
Member

Thanks Tomas!

@weaverryan weaverryan merged commit c88dbe7 into symfony:2.x May 13, 2022
@norkunas norkunas deleted the default-action-validation branch May 13, 2022 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants